Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: isMobile refactor #35

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Chore: isMobile refactor #35

merged 2 commits into from
Apr 3, 2017

Conversation

jeremypress
Copy link
Contributor

  1. Moving isMobile to check the user agent
  2. Checking for mobile browser or ability to download when showing dl button
  3. making sure mobile browsers don't print due to text files not working

tonyjin
tonyjin reviewed Mar 30, 2017
View reviewed changes
src/lib/Preview.js
showDownloadButton(this.download);

if (checkFeature(this.viewer, 'print')) {
if (checkFeature(this.viewer, 'print') && !Browser.isMobile()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this mobile check? We're already in a (canDownload() || !Browser.isMobile()) if block right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because a browser like android chrome for example has the download attribute, but cannot print iFrames that we generate for text files.

@jeremypress jeremypress merged commit d77c0c2 into box:master Apr 3, 2017
@pramodsum pramodsum mentioned this pull request Nov 16, 2017
Merged
pramodsum added a commit that referenced this pull request Nov 16, 2017
@pramodsum
Update: box-annotations to v0.3.1 (#489)
a9580a6 
https://github.com/box/box-annotations/releases

# 0.3.1 (2017-11-15)
* Release: 0.3.1 ([6af2062](box/box-annotations@6af2062))
* Fix: Disable highlight creation when the mobile shared dialog is visible (#35) ([de7f392](box/box-annotations@de7f392))
* Fix: Ensure commentbox event listeners are bound properly (#37) ([fcce638](box/box-annotations@fcce638))
*  Fix: Ensure newly created threads are set as inactive while saving (#38) ([8072fa8](box/box-annotations@8072fa8))
pramodsum added a commit to pramodsum/box-content-preview that referenced this pull request Nov 21, 2017
@pramodsum
Update: box-annotations to v0.4.0
1d4b164 
https://github.com/box/box-annotations/releases

# 0.4.0 (2017-11-21)
* Chore: Cleanup annotations permissions (box#40) ([a52ed54](box/box-annotations@a52ed54))
* Fix: Activate annotation dialog on post (box#42) ([bc001be](box/box-annotations@bc001be))
* Fix: Disable highlight creation when the mobile shared dialog is visible (box#35) ([de7f392](box/box-annotations@de7f392))
* Fix: Don't clear reply textarea when annotation is added to dialog (box#36) ([1f88d55](box/box-annotations@1f88d55))
* Fix: Ensure commentbox event listeners are bound properly (box#37) ([fcce638](box/box-annotations@fcce638))
* Fix: Prevent creation of highlights when a point annotation is pending (box#41) ([42e29ce](box/box-annotations@42e29ce))
* Fix: Validate pendingThreadID when calling onSelectionChange() (box#39) ([10c1c98](box/box-annotations@10c1c98))
* Update: packages (box#43) ([97a91c3](box/box-annotations@97a91c3))
*  Fix: Ensure newly created threads are set as inactive while saving (box#38) ([8072fa8](box/box-annotations@8072fa8))
@pramodsum pramodsum mentioned this pull request Nov 21, 2017
Merged
pramodsum added a commit that referenced this pull request Nov 27, 2017
@pramodsum
Update: box-annotations to v0.4.0 (#497)
808270b 
https://github.com/box/box-annotations/releases

# 0.4.0 (2017-11-21)
* Chore: Cleanup annotations permissions (#40) ([a52ed54](box/box-annotations@a52ed54))
* Fix: Activate annotation dialog on post (#42) ([bc001be](box/box-annotations@bc001be))
* Fix: Disable highlight creation when the mobile shared dialog is visible (#35) ([de7f392](box/box-annotations@de7f392))
* Fix: Don't clear reply textarea when annotation is added to dialog (#36) ([1f88d55](box/box-annotations@1f88d55))
* Fix: Ensure commentbox event listeners are bound properly (#37) ([fcce638](box/box-annotations@fcce638))
* Fix: Prevent creation of highlights when a point annotation is pending (#41) ([42e29ce](box/box-annotations@42e29ce))
* Fix: Validate pendingThreadID when calling onSelectionChange() (#39) ([10c1c98](box/box-annotations@10c1c98))
* Update: packages (#43) ([97a91c3](box/box-annotations@97a91c3))
*  Fix: Ensure newly created threads are set as inactive while saving (#38) ([8072fa8](box/box-annotations@8072fa8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyjin tonyjin tonyjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremypress @tonyjin @JustinHoldstock